Fix Topic Info Test with "Infinite" printing

[emersonknapp]

Connected to ros2/rclpy#722

Fixes the output tests given the new printing info.

[emersonknapp]

@ivanpauno One a side note - do you know a better way to debug when launch_testing.tools.expect_output is failing? I ended up having to write my own little loop in the test to figure out what line was the problem, it looked like:

actual_lines = topic_command.output.splitlines()
for expected_line, actual_line in zip(expected_lines, actual_lines):
    if hasattr(expected_line, 'match'):
        assert expected_line.match(actual_line)
    else:
        assert expected_line == actual_line

(
additionally, do you know if it is possible to isolate these tests? the following selects nothing

colcon test --packages-select ros2topic --event-handlers console_direct+ --pytest-args -k test_topic_endpoint_info_verbose

The only option I could get to work was -k test_cli which only narrows it down to that whole source file, which still takes potentially several minutes to run
)

None of the above is important - this should fix the tests, but if you have insights on the development workflow I would be really happy to hear it.

[emersonknapp]

• Linux
• Linux-aarch64
• macOS
• Windows

[ivanpauno]

@ivanpauno One a side note - do you know a better way to debug when launch_testing.tools.expect_output is failing? I ended up having to write my own little loop in the test to figure out what line was the problem, it looked like:

No, I always modify the test to manually capture the output and print it, or sth like that.
It would be good to improve launch_testing.tools.expect_output so it provides a more useful error message.

colcon test --packages-select ros2topic --event-handlers console_direct+ --pytest-args -k test_topic_endpoint_info_verbose

For cmake packages I use --cmake-args -R <regex_expression_tests_to_run>.
For python I typically go to the test folder and use python -m pytest -s <test_name> ...

Unfortunately for launch_testing tests, I don't think there's a way to only run some of the test cases.
Based on the pytest output:

collected 1 item / 1 deselected

it seems that launch_testing collects everything in one test case (?).

@hidmic may know better.

[ivanpauno]

LGTM with green CI

[ivanpauno]

CI results are here.
Rpr checker is expected to fail until ros2/rclpy#722 gets in (and a new rclpy release is done).

[hidmic]

It would be good to improve launch_testing.tools.expect_output so it provides a more useful error message.

Agreed. It's not the first time someone has complained about this --> ros2/system_tests#404

Unfortunately for launch_testing tests, I don't think there's a way to only run some of the test cases.

There isn't. launch_testing doesn't fully integrate with pytest. I cannot: ros2/launch#405

[audrow]

Looks good to me.