The "leak" is mainly a timing issue on slow CPUs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsumer is slower than producer on low-end CPUs like Raspberry Pi and Odroid. For the moment, a warning and a smaller queue size is the best solution I've been able to come up with...
|
Hmm I'm not too fond on merging this. We can change the default queue size for the video launch file from 1000 to something lower if you insist. It's just an option, I set 1000 based on... nothing, really. |
…cause /use_sim_time has been set to true by Gazebo and rate.sleep() never exited :(
…ithout first going through OpenCV capture that produces uncompressed images using a lot of CPU and RAM
…parameters at the end of what you specified
…llect mjpeg frames
…40x480 resized video stream
…ged launchfile accordingly
…vironment variable within the launchfile
|
@aviogit It looks this PR contains some features that is not related to the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leak in reality is a 1000 slot queue slowly filling up because consumer is slower than producer on low-end CPUs like Raspberry Pi and Odroid. For the moment, a warning and a smaller queue size is the best solution I've been able to come up with.
Maybe I could also add a framesQueue.pull() if memory usage is > some threshold and queue size is > than a couple of seconds worth of video?