Replace build and run depend of opencv2 with opencv3. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To which ROS versions should this apply? Which are not compatible? |
|
Maybe only indigo. I've not tried with any other versions. Then, also I found the vision_opencv package. Instead of ros-indigo-opencv3, is it better to replace opencv2 with vision_opencv? I'm not sure about these dependency and relations. |
|
The usual ROS recommendation for compatibility with multiple distributions is to depend on |
|
That sounds make sense and I feel cv_bridge is the most popular package in the opencv related packages. Therefore, is it suitable to replace opencv2 with cv_bridge for this PR? |
|
Perhaps, although I am not certain. It would require testing on multiple distros. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosdep install gscam
does not work because ros-indigo-opencv2 is deprecated.
Insread, ros-indigo-opencv3 is available, so I replaced opencv2 with opencv3 in package.xml.