Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix <alpha-value> Tailwind placeholder #2369

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

StudioRectangle
Copy link
Contributor

Replace the special placeholder. Tailwind CSS uses this placeholder to inject the alpha value when using an opacity modifier. The placeholder has been replaced with the default value of 1. Currently, the color value is copied as is, leading to broken colors such as --wp-preset-color--primary: rgba(0 0 0 / ). This fix ensures that the value is replaced with --wp-preset-color--primary: rgba(0 0 0 / 1).

Type of change

PATCH: backwards compatible change

Replace the special <alpha-value> placeholder. Tailwind CSS uses this placeholder to inject the alpha value when using an opacity modifier. The placeholder has been replaced with the default value of 1. Currently, the color value is copied as is, leading to broken colors such as --wp-preset-color--primary: rgba(0 0 0 / <alpha-value>). This fix ensures that the value is replaced with --wp-preset-color--primary: rgba(0 0 0 / 1).
Copy link
Member

@kellymears kellymears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you very much for this. I didn't know about this feature at all. Couple easy changes and then I'm happy to merge this. 🙏🏼

@kellymears kellymears added the 🚀! automerge label Jul 10, 2023
@kodiakhq kodiakhq bot merged commit ea427ad into roots:main Jul 10, 2023
8 checks passed
@kellymears
Copy link
Member

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants