-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add SimpleChannel::NotifyProducer function #314
Open
romange
wants to merge
1
commit into
master
Choose a base branch
from
Wake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to support cancellation of the producer when it is stack in a loop trying to push to the queue but its slots are full. This will solve the bug we saw with debug populate and replication in df. The problem is not that the producer is sleeping, the problem is that the producer infinitely tries to push on a channel that's never empty and never drained. If we support cancellation, the producer will back off, skip the push and continue with its thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unaware of this bug, nor I understand how a producer can be stuck if a channel is not full. it should succeed with the push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am talking about this one. dragonflydb/dragonfly#3649
That's the bug. The producer is stuck trying to push because the channel is full and it's blocked. Then the replication is cancelled, the fiber that handles full sync drains the channel but before the cancellation process (another fiber) kicks in the channel gets filled again. Then cancellation fiber kicks in and tries to unregister from the journal but the fiber that is trying to write to the journal is blocked because the channel is full and we
deadlock
. What solves this cycle is a cancel flag. I even wrote it internally on google chat 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It get's worse when the replica has more flows (because it has more proactors than master) because then multiple threads push to the same channel which gets filled even quicker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is unrelated to the bug.