added controls to display, select, add, and remove automation configs #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let showModal; | ||
| let inputValue = ''; | ||
| let _inputValue = inputValue; |
There was a problem hiding this comment.
What's the reason for having both inputValue and _inputValue?
There was a problem hiding this comment.
_inputValue changed at a high cadence (with every key press) and needed inputValue to update on commit - may have changed since I added and will revisit this
Comment on lines
91
to
93
| <link | ||
| rel="stylesheet" | ||
| href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" /> |
There was a problem hiding this comment.
We already have an icons library available, so let's remove this dynamic web import in favor of those.
Here's the list of all icons available. https://code.visualstudio.com/api/references/icons-in-labels#icon-listing
There was a problem hiding this comment.
yep - in the process of polishing (one reason why I added as a draft, so you could review the functionality while I clean it up)
Co-authored-by: Bronley Plumb <[email protected]>
autorun management functions in a dialog. Functions include adding, copying, removing, and managing order of autoruns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.