-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TC for #138 #143
Add TC for #138 #143
Conversation
I think you are missing a trailing newline at the end of pytest/testdata/03_annotations-3.7.right |
maybe it needs 2 newlines in the file end? |
Here's how to fix. Run your test on one of the failing os's - ubuntu or osx. It should fail but there is a file called xxx.got left in the |
Thanks for the great tip! I didn't know that super tip |
hmm strange things are going on... so I tried Ubuntu 22 and ... I see 0 issues:
any clues how could get the .got file?
|
I've setup also python 3.8 venv and.. its even better - 100% pass rate, eg:
any additional clues please?... |
When I ran on I got an error and when I got the error it had the additional file in it. If a test succeeds then it doesn't include the "got" file. At any rate I think your changes have now all been merged in. Thanks for the work! Please double check though to make sure there isn't still a problem. |
My first TC ever in this repo
please review and give green go or yellow/red card :)