Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Atmega88 #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for Atmega88 #68

wants to merge 2 commits into from

Conversation

mrguen
Copy link
Contributor

@mrguen mrguen commented Sep 11, 2018

Hello,
Just a few changes to support Atmega88/Atmega88A. LowPower BOD is not supported with this MCU.

Copy link
Owner

@rocketscream rocketscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind pulling the latest revision to make the changes? You are using 1.60 instead of 1.70.

@mrguen
Copy link
Contributor Author

mrguen commented Sep 14, 2018 via email

@rocketscream
Copy link
Owner

rocketscream commented Sep 15, 2018

Yes, I would do it.

Sorry but I think I made a mistake on V1.70 as it was merged from a pull request without me checking the release note section which was not update. The code was updated.

Also I would like to know if I should remove any added comments like "MOD TG 14 09 2018".

Yes, please remove it and it supposed to be added to the top portion of the release note section. The V1.70 for ATmega1284P and ATmega644P was missing.

@mrguen
Copy link
Contributor Author

mrguen commented Sep 15, 2018 via email

@mrguen
Copy link
Contributor Author

mrguen commented Sep 26, 2018

Hello,

I downloaded the 1.7 version but the header is still 1.6. That must be the reason for the confusion.

I don't pull request for now but wait for your validation of the 1.7 version.

Sincerely

@rocketscream
Copy link
Owner

rocketscream commented Sep 26, 2018

Okay, fixed with 6cfe933. Sorry for the confusion.
Do bump the revision to V1.80.

@mrguen
Copy link
Contributor Author

mrguen commented Sep 27, 2018 via email

@datenheim
Copy link

Hello, I prepared the release but the commit shows all lines different due to line ending problem. I work on Windows and edit them with TextPad. I don't have the Github client but download / upload from Github. I don't know how to handle this properly with regards to how you do. What should I do? Sincerely

You may decide to give Notepad++ a go, it has options to manipulate line endings automagically.
https://notepad-plus-plus.org/

@mrguen
Copy link
Contributor Author

mrguen commented Oct 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants