Add rten-convert #53
Add rten-convert #53
Conversation
|
Hello - can you remove the converter module and generated schema from the previous location under |
|
Done :) |
|
There is a rule in the project's |
|
Should I update Readme file, specifically the places where model conversion is specified? I assume you are planning to add rten-convert to pypi, aren't you? |
Yes please, and yes, I plan to upload it to PyPI. |
|
I have updated readme files and comments in example code. For now I have specified installation from the repository, but once you add the package to PyPi, will need to correct the installation of the package from PyPI. |
- Update dependencies of the `all` target - Update the output directory for `schema_generated.py`
rten-cli/src/main.rs
Outdated
| @@ -293,7 +293,8 @@ fn print_input_output_list(model: &Model, node_ids: &[NodeId]) { | |||
| /// generated inputs. | |||
| /// | |||
| /// ``` | |||
| /// tools/convert-onnx.py model.onnx output.rten | |||
| /// pip install -e rten-convert | |||
There was a problem hiding this comment.
In the instructions in examples and other tools I think it will make sense to assume the user has followed the basic installation steps in the main README, so we don't need to duplicate the instructions for installing rten-convert in each example. This was already assumed to be the case for the dependencies of tools/convert-onnx.py.
There was a problem hiding this comment.
I removed unnecessary installation references
|
Thanks for this. I will publish the tool to PyPI as part of the next RTen release. |
This implements #45.