int8 and uint8 support in Pad and other ops #387
+107
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-yusupov
changed the title
igor-yusupov
changed the title
.DS_Store
Outdated
There was a problem hiding this comment.
Can you remove this macOS-specific .DS_Store file. I suggest creating a global .gitignore for this.
There was a problem hiding this comment.
Done. Sorry, I accidentally pushed that file. I also updated .gitignore file.
I think we need to make squash commit to not have this file in git history
| Input::Int8Tensor(t) => Ok(t.map_in(pool, |x| *x as f32).into()), | ||
| Input::UInt8Tensor(t) => Ok(t.map_in(pool, |x| *x as f32).into()), | ||
| }, | ||
| DataType::Int8 => match input { |
There was a problem hiding this comment.
I think that using as for casts is fine for all cases here. Just making some notes for myself:
Converting non-i8 types to i8 will truncate in various ways, and the same for u8. The Cast op specs are here. The main cases of interest are:
- Float -> int when out of range: ONNX spec says undefined, so an
ascast is fine - Int -> Int when out of range: ONNX spec says
when OOR, discard higher bits and reinterpret (with respect to two’s complement representation for signed types). For example, 200 (int16) -> -56 (int8).. This matches the behavior ofasin Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.