Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes in order to get it to work in robot framework v6.1.1 #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huibboschtt
Copy link

No description provided.

@huibboschtt
Copy link
Author

I hope you appreciate my contribution and merge it, I'd guess this will help people to get it to work as there are many posts on the internet about it.

@@ -0,0 +1,13 @@
*** Settings ***
Library AsyncLibrary/AsyncLibrary.py WITH NAME ASYNCLIBRARY
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks that you are trying to help, but I have a couple of issues with your proposal.

When I understand it correctly, you stumble only across all the problems, because you did not install the library as a python module as should be the case. So in other words, was the code installed via one of the methods proposed. Also did you try the examples?

Also the resource file here, I do not see an added value when you follow the example and the unit test in the test folder. Robot Framework 6.0.1 is also tested in the CI/CD pipeline. Thus this is working.

Further, pylint will complain about the changes you introduced as the import is not correctly done as part of your changes.

Regarding the introduction of AsyncLibrary.py file. Was the code actually changed and what or was the code only moved?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, RF 6.1.1 was not part of the CI/CD pipeline test, yet. Just added that tests are also executed against it and everything is working as expected. No changes required. You can look at the last actions what is all tested or easier in the pipeline file. Here an example of ubuntu latest, python 3.8 and RF 6.1.1
https://github.com/rlehfeld/robotframework-async-keyword/actions/runs/11157689805/job/31012453021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants