Redesign ComponentAccessExpr, improve error diagnostics
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
yay :) |
|
I think there is a regression. My code suddenly stops working (I can't see entities or anything on my server) when using 8ab990d. It works perfectly fine on https://github.com/andrewgazelka/evenio/tree/fix-collisions-gt-2?branch=fix-collisions-gt-2 |
rj00a
added a commit
that referenced
this pull request
Apr 6, 2024
`Not<Q>` queries weren't being handled correctly in `matches_archetype`. There are now unit tests to cover this. Should fix the issue mentioned in #35 (comment)
|
@andrewgazelka Should be fixed in #37. Let me know if you run into anything else. |
Fixed for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns the
ComponentAccessExprtype to track access conflicts more precisely. Queries such asOr<Or<(&mut A, With<&B>), (&A, Not<&B>)>, (&A, Not<&B>)>and(&mut A, &mut A, Not<&A>)will now pass the component access checker.Additionally, we now defer access errors until after handler init has finished. This improves diagnostics by showing a list of all access conflicts together.
TODO