-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign ComponentAccessExpr
, improve error diagnostics
#35
Conversation
yay :) |
I think there is a regression. My code suddenly stops working (I can't see entities or anything on my server) when using 8ab990d. It works perfectly fine on https://github.com/andrewgazelka/evenio/tree/fix-collisions-gt-2?branch=fix-collisions-gt-2 |
`Not<Q>` queries weren't being handled correctly in `matches_archetype`. There are now unit tests to cover this. Should fix the issue mentioned in #35 (comment)
@andrewgazelka Should be fixed in #37. Let me know if you run into anything else. |
Fixed for me :) |
This PR redesigns the
ComponentAccessExpr
type to track access conflicts more precisely. Queries such asOr<Or<(&mut A, With<&B>), (&A, Not<&B>)>, (&A, Not<&B>)>
and(&mut A, &mut A, Not<&A>)
will now pass the component access checker.Additionally, we now defer access errors until after handler init has finished. This improves diagnostics by showing a list of all access conflicts together.
TODO