Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass target location through System::run. #14

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

rj00a
Copy link
Owner

@rj00a rj00a commented Feb 13, 2024

Prior to this change, receivers used the event's declared target entity to fetch their query data. This is unsound because the event's target could be changed via mutable receivers. Bad implementations of Event were also possible.

Prior to this change, receivers used the event's declared target entity
to fetch their query data. This is unsound because the event's target
could be changed via mutable receivers. Bad implementations of `Event`
were also possible.
@rj00a rj00a merged commit b452eb5 into main Feb 13, 2024
6 checks passed
@rj00a rj00a linked an issue Feb 13, 2024 that may be closed by this pull request
@rj00a rj00a deleted the targeted_event_fix branch February 13, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutable events can change the event target
1 participant