Attendance Command #142
Open
Attendance Command #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootsie123
reviewed
Sep 29, 2024
|
|
||
| for _, signinType := range signinTypes { | ||
| var entSigninType signin.Type | ||
| switch signinType { |
There was a problem hiding this comment.
@c0untingNumbers I'll pass it for this PR but just as a heads up, I noticed in a few other places we're hard coding the signin types as a string and putting it through a giant switch statement. I'll make an issue about it but could you look into refactoring this?
Ideally, we'd declare both in one place with a simple helper function which can then be called everywhere else (or something along these lines). Thanks!
There was a problem hiding this comment.
Yeah, good idea. Will put that up for an issue.
bootsie123
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added /attendance command that will show total signins and signins by type for the user.