Merge pull request #250 from C-53/bugfix-msvc2015-stream-buffer

[Fix] Unbuffered streams causing poor performance with MSVC 2015
rikyoz · Oct 6, 2024 · 003b7a0 · 003b7a0
2 parents bec6a22 + 1464c11
commit 003b7a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/internal/cfileinstream.cpp b/src/internal/cfileinstream.cpp
@@ -22,7 +22,10 @@ CFileInStream::CFileInStream( const fs::path& filePath ) : CStdInStream( mFileSt
      * Note: we need to do this before and after opening the file (https://stackoverflow.com/a/59161297/3497024). */
     mFileStream.rdbuf()->pubsetbuf( nullptr, 0 );
     openFile( filePath );
+// Unbuffered streams are slow for Visual Studio 2015
+#if !defined(_MSC_VER) || _MSC_VER != 1900
     mFileStream.rdbuf()->pubsetbuf( nullptr, 0 );
+#endif
 }
 
 void CFileInStream::openFile( const fs::path& filePath ) {

diff --git a/src/internal/cfileoutstream.cpp b/src/internal/cfileoutstream.cpp
@@ -42,7 +42,10 @@ CFileOutStream::CFileOutStream( fs::path filePath, bool createAlways )
         throw BitException( "Failed to open the output file", last_error_code(), path_to_tstring( mFilePath ) );
 #endif
     }
+// Unbuffered streams are slow for Visual Studio 2015
+#if !defined(_MSC_VER) || _MSC_VER != 1900
     mFileStream.rdbuf()->pubsetbuf( nullptr, 0 );
+#endif
 }
 
 auto CFileOutStream::fail() const -> bool {