Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another set of refactoring changes #120

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Another set of refactoring changes #120

wants to merge 8 commits into from

Conversation

LiamMehle
Copy link

Set of commits includes:

  • optimizations to avoid allocating some of the strings on the heap repeatedly in the menu,
  • renaming of some variables,
  • marking functions as static since they're not used outside of the menu_utils.cpp translation unit,
  • using an enum instead of literal numbers when checking bluetooth type
  • a bit of cleanup

@LiamMehle
enum instead of magic numbers
75e282b
@LiamMehle
local convenience functions marked static
220879a 
if they're not used in other translation units, functions can be marked static to avoid them being needlessly exported by the compiler
@LiamMehle
marking variables as const
c2480d9 
marking variables as const is generally good practice
@LiamMehle
unused exports removed form header
38ae715
@LiamMehle
fixed typos
1c6ff99
@LiamMehle
optimization to avoid constant heap allocation
9cb3372 
`String` is a heap-allocated string. One is created implicitly due to the return type of the helper functions. They're not mutated, so a reference to a static String that is allocated once can be returned instead.
@LiamMehle
same as last commit, but for 2 other functions
f589491
@LiamMehle
no need to break after return
a33294e 
returning from a function returns control flow back to the calling function immediately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LiamMehle