Fix layout issue in instance dashboard #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coleenquadros
approved these changes
Jul 7, 2023
|
LGTM :) |
|
I think two more rows need to be updated(https://github.com/rhobs/configuration/pull/542) |
thibaultmg
approved these changes
Jul 7, 2023
Signed-off-by: Vibhu Prashar <[email protected]>
|
Updated Dashboard |
coleenquadros
approved these changes
Jul 7, 2023
Initially, I also thought to fix this upstream but if everyone else is using why didn't they face the similar layout problem which we did? Is it because we use a different Grafana version or is it something related to our environment? I am still not clear on this that's why I didn't touch upstream. But yes if this is a genuine case then we should update upstream as well |
saswatamcode
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In thanos mixin builder.libsonnet we import grpc.libsonnet, http.libsonnet, slo.libsonnet and uses their functions like
httpQpsPanel,httpErrPanel,latencyPaneletc for creating respective panels in our libsonnet. Since these function's don't have the property to change the span size and without that, they pick up the default values from this. It's best to remove the span property completely as it interferes with the default layout sizing which grafana provides as removing the span property allows grafana to dynamically size the panels inside a row.Link to dashboard using generated JSON