Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python install and upgrade versions to allow 3.11 installation #374

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jmfrank63
Copy link

Tested on a Mac M1. Should fix
pip install piper-tts, which already created several issues.

Upgraded several requirement versions.

Also fixed Readme formatting and changed
the teaser to reflect the python runnable command.

@jmfrank63
Copy link
Author

MacOS works, tested on M1. Windows is now also working (amd64). Linux will follow. If you want to run this, set
PIPER_PHONEMIZE_REPO and point it to this or your fork. Omit the .git in the URL.

@rmcpantoja
Copy link
Contributor

Hi @jmfrank63,
Pls take into account the review of pytorch-lightning~=2.1.0 LINE. This needs a big change in the training code. It could be changed up to 1.9.x at the moment.

@jmfrank63
Copy link
Author

@rmcpantoja Yes, you might be right. I gave it a try, it compiles and installs on macOS and Windows. The basic example works on both. But then I tried a Russian example on Windows and the result is just rubbish. This could be either to the fact that I had to use hex code points for getting it to compile or some other reason. We definitely need more tests.
I don't know where to go from here exactly, so I wait until the maintainer @synesthesiam provides some guidance.

@rmcpantoja
Copy link
Contributor

rmcpantoja commented Feb 5, 2024

@rmcpantoja Yes, you might be right. I gave it a try, it compiles and installs on macOS and Windows. The basic example works on both. But then I tried a Russian example on Windows and the result is just rubbish. This could be either to the fact that I had to use hex code points for getting it to compile or some other reason. We definitely need more tests. I don't know where to go from here exactly, so I wait until the maintainer @synesthesiam provides some guidance.

No, pytorch lightning It has nothing to do with installing piper_phonemice in Python, since they are different packages. pytorch lightning is only used by the piper_train package. If you want to support pl >2, you need to update the piper_train training code, especially using LightningCli instead of argparse.

@0xb15d3
Copy link

0xb15d3 commented Feb 18, 2024

@synesthesiam thanks for all the hard work, but this is stopping me from using piper. Is this project unmaintained?

@torntrousers
Copy link

Hello, would this PR fix the problem here #384, and if so how would i go about using this PR with a Python app using Piper?

@a-andre
Copy link

a-andre commented Apr 17, 2024

This PR contains a lot of unrelated changes.

The changes to CMakeLists.txt should be removed.

AFAIK, Windows doesn't have make (and if it does the test should be fixed to work there, in case it is currently broken), i.e. no need to modify the Makefile.

Because of the style changes it is difficult to detect if the content of README.md has been changed. The style/format should be changed in a separate commit if at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants