feat: including "replying to" in copy text (resolve #172) #188
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Rexogamer
changed the title
|
Would it not be possible to include hidden text directly in the |
Sorry for the late response... I've pushed a commit, could you please recheck it? |
There was a problem hiding this comment.
Sorry currently doing exams but, there is still quite a large diff on this PR.
There is at least one issue reading this that could cause a crash but beyond that I would probably refactor this further into just one file, in theory you should be able to just define the "ReplyHelperComponent" styled span component in MessageReply itself and then use it as appropriate.
| </NonBreakingText> | ||
| <Show when={props.message!.attachments}> | ||
| <> | ||
| <MessageReplyCopyHelper message={props.message!} /> |
There was a problem hiding this comment.
If props.message is not yet defined then this would crash out.
| </NonBreakingText> | ||
| </Show> | ||
| <Show when={props.message!.content}> | ||
| <OverflowingText> |
There was a problem hiding this comment.
Invisible text could be placed above this with user-select enabled.
(the reply span styled component would also be defined in this file)
|
PR went stale, feedback not responded to, closing out for now |
Please make sure to check the following tasks before opening and submitting a PR
Tricking copying "replying to" text into the keyboard by adding an invisible element, as suggested at #172. Hope this changes look good :)