Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include "replying to" in copy text #172

Open
insertish opened this issue Apr 5, 2023 · 4 comments · May be fixed by #285
Open

feat: include "replying to" in copy text #172

insertish opened this issue Apr 5, 2023 · 4 comments · May be fixed by #285
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@insertish
Copy link
Member

insertish commented Apr 5, 2023 •
edited
Loading

Screenshot 2023-04-20 at 11 23 03

Expected copy text:

Vale
Today at 11:15
...

[11:15]
:trol:

Replying to SushiBlade: did you actually
expertlokiofficial
Today at 11:16
:01GNT73EJV7941KKE9TAYT337F:

[11:17]
BCR is a bank

Actual copy text:

Vale
Today at 11:15
...

[11:15]
:trol:


expertlokiofficial
Today at 11:16
:01GNT73EJV7941KKE9TAYT337F:

[11:17]
BCR is a bank

Difference:

[11:15]
:trol:

+ Replying to SushiBlade: did you actually
expertlokiofficial
Today at 11:16

Much like the timestamps, this can be done using invisible text.
@insertish insertish added enhancement New feature or request help wanted Extra attention is needed labels Apr 20, 2023
@insertish insertish added this to the Channels / Messaging milestone Apr 20, 2023
@JackDotJS
Copy link
Contributor

if nobody else does, i might try tackling this after #173 / #182

@kimlimjustin
Copy link

@JackDotJS have you started working on this? I've figured out a way to handle this, what left is just to open a PR

@JackDotJS
Copy link
Contributor

nope, i'm still waiting for approval on the other PR x) feel free to take this one!

@kimlimjustin kimlimjustin mentioned this issue Apr 23, 2023
Closed
3 tasks
@insertish insertish removed this from the Channels / Messaging milestone Mar 28, 2024
JackDotJS added a commit to JackDotJS/frontend that referenced this issue Jun 4, 2024
@JackDotJS
wip: add hidden text for message replies (revoltchat#172)
4527698
@JackDotJS JackDotJS linked a pull request Jun 4, 2024 that will close this issue
Draft
2 tasks
@JackDotJS
Copy link
Contributor

seeing as #188 kinda fell apart a while back, i figured i'd try sorting this out myself x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Revolt Project
Status: 🕒 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: include replies in copied text JackDotJS/frontend
3 participants
@JackDotJS @insertish @kimlimjustin