-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Notifications to the new API #3103
Open
cesarvarela
wants to merge
104
commits into
responsible-ai-collaborative:staging
Choose a base branch
from
aiidtest:feature-migrate-notifications
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate Notifications to the new API #3103
cesarvarela
wants to merge
104
commits into
responsible-ai-collaborative:staging
from
aiidtest:feature-migrate-notifications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classifications-taxa
This reverts commit 5d3aed2.
…classifications-taxa
…classifications-taxa
…classifications-taxa
…classifications-taxa
pdcp1
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3156
Working deploy preview: https://pr-3103--staging-aiid.netlify.app
Notifications will be sent to your staging user email.
Environment updates:
SITE_URL
must be set in Github and Netlify for bothstaging=https://stating-aiid.netlify.com
andhttps://incidentdatabase.ai
. This value is used for email templates and to let the process notifications plugin know where the API endpoint is.MAILERSEND_API_KEY
needs to be added to Netlify in both staging and production. It should be a different one, scoped to a different email account if possible.NOTIFICATIONS_SENDER_NAME
Name of the notifications sender, i.e. AIID Notifications, must be added to staging and production Netlify environments and should be different on each.NOTIFICATIONS_SENDER
email account sending the notifications i.e. [email protected], should be added to both Netlify staging and production envs, and should be a different account for each.note
We'll still be using Sendgrid to send all authorization-related emails (e.g., "forgot password," "email confirmation," etc.). We should discuss whether it is worth moving those to Mailersend or switching authorization (leaving Atlas behind completely 😮) to something like magic login links.