-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add right sidebar content for prismic content #2795
base: staging
Are you sure you want to change the base?
Add right sidebar content for prismic content #2795
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2795 +/- ##
========================================
Coverage 96.73% 96.73%
========================================
Files 35 35
Lines 9408 9408
Branches 130 182 +52
========================================
Hits 9101 9101
Misses 307 307 ☔ View full report in Codecov by Sentry. |
Passing run #2478 ↗︎
Details:
Review all test suite changes for PR #2795 ↗︎ |
@cesarvarela ready for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this review.
Please migrate the test to Playwright.
In order for the right side
Content
to work with Prismic rich text, we need to add IDs to headers (h1 and h2) for anchors to work. Since richtext is not Markdown, this needs to be done manually (without any plugins)Working examples:
https://pr-2795--staging-aiid.netlify.app/blog/incident-report-2024-january/
https://pr-2795--staging-aiid.netlify.app/about/