Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Empty Env site build #2528

Draft
wants to merge 15 commits into
base: staging
Choose a base branch
from
Draft
90 changes: 48 additions & 42 deletions site/gatsby-site/cypress/e2e/integration/citeEdit.cy.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { maybeIt } from '../../support/utils';
import { conditionalIt, maybeIt } from '../../support/utils';
import updateOneReport from '../../fixtures/reports/updateOneReport.json';
import updateOneReportTranslation from '../../fixtures/reports/updateOneReportTranslation.json';
import { format, getUnixTime } from 'date-fns';
Expand Down Expand Up @@ -500,7 +500,9 @@ describe('Edit report', () => {

cy.visit(url);

cy.wait(['@FindIncidents', '@FindIncidentsTitles', '@FindReportWithTranslations']);
cy.wait('@FindIncidents');
cy.wait('@FindReportWithTranslations');
!Cypress.env('isEmptyEnvironment') && cy.wait('@FindIncidentsTitles');

cy.conditionalIntercept(
'**/graphql',
Expand Down Expand Up @@ -753,57 +755,61 @@ describe('Edit report', () => {
cy.contains('[data-cy="toast"]', 'Incident report 23 updated successfully', { timeout: 8000 });
});

maybeIt('Should display an error message if data is missing', () => {
cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'FindReportWithTranslations',
'findReportWithTranslations',
reportWithTranslations
);
conditionalIt(
!Cypress.env('isEmptyEnvironment'),
'Should display an error message if data is missing',
() => {
cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'FindReportWithTranslations',
'findReportWithTranslations',
reportWithTranslations
);

cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'ProbablyRelatedReports',
'ProbablyRelatedReports',
{
data: { reports: [] },
}
);
cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'ProbablyRelatedReports',
'ProbablyRelatedReports',
{
data: { reports: [] },
}
);

cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'ProbablyRelatedIncidents',
'ProbablyRelatedIncidents',
{
data: { incidents: [] },
}
);
cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'ProbablyRelatedIncidents',
'ProbablyRelatedIncidents',
{
data: { incidents: [] },
}
);

cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'FindIncidents',
'FindIncidents',
{ data: { incidents: [] } }
);
cy.conditionalIntercept(
'**/graphql',
(req) => req.body.operationName == 'FindIncidents',
'FindIncidents',
{ data: { incidents: [] } }
);

cy.visit(`/cite/edit?report_number=23`);
cy.visit(`/cite/edit?report_number=23`);

cy.wait('@findReportWithTranslations');
cy.wait('@findReportWithTranslations');

cy.get('form[data-cy="report"]').should('be.visible');
cy.get('form[data-cy="report"]').should('be.visible');

cy.get('[name="title"]').clear();
cy.get('[name="title"]').clear();

cy.contains('Please review report. Some data is missing.').should('exist');
cy.contains('Please review report. Some data is missing.').should('exist');

cy.contains('button', 'Submit').should('be.disabled');
cy.contains('button', 'Submit').should('be.disabled');

cy.get('[name="title"]').type(
'Remove YouTube Kids app until it eliminates its inappropriate content'
);
cy.get('[name="title"]').type(
'Remove YouTube Kids app until it eliminates its inappropriate content'
);

cy.contains('button', 'Submit').should('not.be.disabled');
});
cy.contains('button', 'Submit').should('not.be.disabled');
}
);

maybeIt('Should convert an issue to a incident report', () => {
cy.login(Cypress.env('e2eUsername'), Cypress.env('e2ePassword'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const onPostBuild = async function ({
await run('echo', [
result?.data?.createDefaultAdminUser?.userId
? `${result?.data?.createDefaultAdminUser?.userId} Admin user created`
: 'Admin user already exists',
: 'Admin user not created',
]);
} catch (error) {
// Report a user error
Expand Down
5 changes: 1 addition & 4 deletions site/realm/functions/createDefaultAdminUser.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,7 @@ exports = async (input) => {
};
}
else {
return {
status: 500,
message: "Can't create the Admin user.",
}
return response;
}
}

Expand Down
Loading