Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow splitting entity path expressions with whitespace #7782

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 16, 2024

What

This is a little tricky since we don't want to split on whitespace that happens to show up between a + or - and the expression.

Logic seems correct from testing.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🪵 Log & send APIs Affects the user-facing API for all languages include in changelog 🟦 blueprint The data that defines our UI labels Oct 16, 2024
@jleibs jleibs marked this pull request as ready for review October 16, 2024 17:52
@jleibs jleibs removed the 🟦 blueprint The data that defines our UI label Oct 16, 2024
@jleibs jleibs added this to the 0.19 - Dataframe and video milestone Oct 16, 2024
.github/workflows/labels.yml Outdated Show resolved Hide resolved
@emilk emilk merged commit d6d8275 into main Oct 17, 2024
32 of 33 checks passed
@emilk emilk deleted the jleibs/split_on_whitespace branch October 17, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex content expressions don't parse in dataframe API
2 participants