Allow color specification on Asset3D
#7458
Open
+178
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 30, 2024 14:43
- add attribute `albedo_factor` and method `with_albedo_factor` to archetype `Asset3D`. - update stl/obj loader : `load_stl_from_buffer` and `load_obj_from_buffer` to process `albedo_factor`.
Remove `albedo_texture_buffer`, `albedo_texture_format` from `Asset3D`
- add attribute `vertex_colors` and method `with_vertex_colors` to archetype `Asset3D`. - update stl/obj loader : `load_stl_from_buffer` and `load_obj_from_buffer` to process `vertex_colors`.
EtaLoop
force-pushed
the
color-in-asset3d
branch
from
917d889
to
161224d
Compare
Wumpf
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks for your contribution!! 🙂
AlbedoFactor makes a lot of sense to me since this can be applied on all mesh/model formats, would love to get this in. But I don't see yet how we can add vertex_colors in a tractable & defined way. However, maybe we can come up with some rule for it?
Very relatedly, we have to keep in mind that more model formats may be added in the future and we need to avoid ugly surprises in that context. Therefore, I think all additional properties on Assed3D should be "postprocesses" on the loaded mesh. This makes it more robust against future formats and makes it a lot easier to specify what they do.
EtaLoop
force-pushed
the
color-in-asset3d
branch
from
e69b313
to
6b1a7b0
Compare
|
let me know when you think this is ready for review again! :) |
EtaLoop
force-pushed
the
color-in-asset3d
branch
2 times, most recently
from
36c02cd
to
87751a4
Compare
added 3 commits
October 3, 2024 15:53
- remove `albedo_factor` from loader
EtaLoop
force-pushed
the
color-in-asset3d
branch
from
87751a4
to
f8ff765
Compare
Wumpf
reviewed
Oct 11, 2024
Wumpf
requested changes
Oct 11, 2024
crates/viewer/re_space_view_spatial/src/visualizers/assets3d.rs
Outdated
Show resolved
Hide resolved
added 2 commits
October 11, 2024 11:19
- Add #derive[(Clone)] instead of impl Clone for MeshInstance
EtaLoop
force-pushed
the
color-in-asset3d
branch
from
0d5945b
to
38f4044
Compare
6 tasks
1 task
Wumpf
added a commit
that referenced
this pull request
Oct 22, 2024
### What This is mainly a refactor of `re_renderer`'s model loading pipeline, but as the title (== changelog entry) points out, a nice side-effect that arose culling unnecessary memory usage which may be important for large meshes. @EtaLoop's attempt to add a color option to `Asset3D` (see #7458) made it clear that the output of the mesh loaders is really hard to work with: Prior to this PR, they would eagerly create gpu-sided meshes and then store them alongside an optional (but always filled-out) "cpu mesh" (in essence the unpacked model file). Now instead all model loading goes to a intermediate `CpuModel` which can be rather easily post processed. Gpu resources are then created as a separate step, consuming the `CpuModel` (it should be trivial to create a variant that doesn't consume if we need this in the future) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7824?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7824?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7824) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
|
Now that #7824 is in, it should be a lot more straight forward to do this! |
|
Thanks a lot 👍 |
EtaLoop
commented
Oct 22, 2024
| render_ctx: &RenderContext, | ||
| albedo_factor: &Option<AlbedoFactor>, |
There was a problem hiding this comment.
Should I pass the whole Asset3D or just bytes and albedo_factor?
There was a problem hiding this comment.
doesn't matter much, but I reckon all callsites have Asset3D ready already? Then might as well pass the whole thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The idea is to reproduce behavior of
Mesh3Dregarding color modification onAsset3D:albedo_factorvertex_colorsas inMesh3DIn order to overwrite white default texture of
Asset3Dloaded from stl and obj (gltf already have albedo_factor in file).See: #5253
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.