Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Maximum Number Of Host Parameters In A Single SQL Statement #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

C2H6O
Copy link

@C2H6O C2H6O commented Jan 13, 2020

This PR is a follow-up to #124. Is this something that can be merged into this repo, instead of us having to fork it?

@npurushe
Copy link
Contributor

If this change doesn't negatively effect memory usage in a typical use case then should be able to merge it. May also be possible to configure it this way and then lower the limit at runtime and have it be configurable somehow. Will look into this!

C2H6O added a commit to plangrid/sqlite-android that referenced this pull request Feb 14, 2020
See requery#125 for details.

This PR contains code changes that are currently live in the prod artifact (see plangrid/plangrid-android#8016 where the dependency was updated from io.requery:sqlite-android to io.requery:sqlite-android-plangrid). I had to work with devops to manually upload the artifact that I created locally because developers don't have access to uploading things to artifactory. Once JENKINS is setup, it'll have access to uploading artifacts to our artifactory.

Follow-ups:
- Update README with PlanGrid specific notes about the changes
- Setup JENKINS for Publishing
- Mark https://github.com/plangrid/SQLite-FTS5-Android as deprecated
- Update https://github.com/plangrid/SQLite-FTS5-Synonyms-Android to remove SQLite-FTS5 submodule, update JENKINS to no longer publish SQLite-FTS5, and remove any reference to SQLite-FTS5 from that repo
@falcon4ever
Copy link
Contributor

https://www.sqlite.org/limits.html

To prevent excessive memory allocations, the maximum value of a host parameter number is SQLITE_MAX_VARIABLE_NUMBER, which defaults to 999 for SQLite versions prior to 3.32.0 (2020-05-22) or 32766 for SQLite versions after 3.32.0.

Since SQLite v3.35.5 got merged in last week does this mean it will use the new defaults (i.e. 32766 for SQLITE_MAX_VARIABLE_NUMBER)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants