Support ruby3 #12
Open
Support ruby3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
rexml
aws-sdk-core requires either libxml,nokogiri,oga,ox or rexml. https://github.com/aws/aws-sdk-ruby/blob/7b563dc8389ad4d1604a652a5cd3c8ace622208a/gems/aws-sdk-core/lib/aws-sdk-core/xml/parser.rb#L70-L72
In ruby3 rexml gem is not installed by default https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Now rexml dependent on crack from v0.4.5 jnunemaker/crack#62 .
But I think it was just a coincidence.
So, I add rexml to runtime dependency.
Application using mini_paperclip can use nokogiri or others if it's installed.