Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/crdant/makes sure tmux runs #356

Closed
wants to merge 2 commits into from
Closed

fix/crdant/makes sure tmux runs #356

wants to merge 2 commits into from

Conversation

crdant
Copy link
Member

@crdant crdant commented Oct 14, 2024

  • Repairs solve for first "Delivering..." challenge
  • Adapts "Delivering..." to Embedded Cluster chagnes

@crdant
Repairs solve for first "Delivering..." challenge
02e13ec 
TL;DR
-----

Makes sure the tmux sesesion exists to avoid solve script error

Details
-------

Fixes an issues where tests were failing because the solve script for
the first challenge in the "Delivering Your Application as a Kubernetes
Appliacne" lab was trying to send to tmux before the session existed.
@crdant
Adapts "Delivering..." to Embedded Cluster chagnes
7a7fa92 
TL;DR
-----

Updates the "Delivering..." lab for changes to Embedded Cluster

Details
-------

Restores the "Delivering Your Application as a Kubernetes Appliance" lab
to working order. The lab stopped working when changes to the embedded
cluster relocated the `admin.conf` file that a few scripts referenced as
their `KUBECONFIG`.

Also takes advantage of the new(ish) `--admin-console-password` flag to
set the Admin Console password in in the solve script for the fifth
challenge. The earlier script used KOTS to set the password, but
streamlining it to the expected approach feels a lot cleaner and
future-proof.
@crdant crdant requested a review from xavpaice as a code owner October 14, 2024 16:55
@crdant crdant added the type::bug Something isn't working label Oct 14, 2024
@crdant crdant closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavpaice xavpaice Awaiting requested review from xavpaice xavpaice is a code owner

@adamancini adamancini Awaiting requested review from adamancini adamancini is a code owner

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crdant