Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all_enty occurrences which only depend on emiTe #500

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from

Conversation

spahrm
Copy link

@spahrm spahrm commented Sep 14, 2021

This PR is the first part of the refactoring of the all_enty from Remind. Replacing this set step by step improves readability and makes it more clear which part of the set is actually used in equations, parameters and variables.
In the first step a report was generated which contains all variables,parameters and equations, depending on all_enty, but actually only in a subset form from the set emiTe. This report can be found here:
emiTeReport.csv

Afterwards all occurrences of these variables where located in the remind folder and replaced with emiTe instead of all_enty. After each replacement a testOneRegi run was performed to check if simulation results alter. After all possible variables were renamed, SSP and policy runs where executed to check the simulation results even more carefully.
There are changes between the develop and the emiTe runs, please review them carefully.

Mike Spahr and others added 30 commits August 27, 2021 09:33
…ly depending on emiTe. No changes in testOneRegi
…demand, o_emissions_energy_supply_gross, o_emissions_energy_supply_gross_carrier s all_enty to emiTe. No changes in testOneRegi
@spahrm spahrm self-assigned this Sep 14, 2021
@spahrm spahrm marked this pull request as ready for review September 15, 2021 08:49
@chroetz chroetz mentioned this pull request Aug 24, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants