Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing historical.mif in tests because it is an optional input file #1857

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

dklein-pik
Copy link
Contributor

Purpose of this PR

Ignore missing historical.mif in tests, because we are not allowed to publish the validation.tgz (that contains the historical.mif) to external users, but make test should still pass all tests also for external users.

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • [] I checked that the in-code documentation is up-to-date
  • [] I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@dklein-pik dklein-pik marked this pull request as ready for review October 10, 2024 13:12
tests/testthat/test_01-inputdata.R Outdated Show resolved Hide resolved
tests/testthat/test_01-inputdata.R Outdated Show resolved Hide resolved
Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dklein-pik dklein-pik merged commit c8ca954 into remindmodel:develop Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants