-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: windoff capacity factor was too low #1853
Conversation
…ndoff had otherwise very low capacity factors
p_aux_capacityFactorHistOverREMIND(regi,teVRE) $ (p_histCapFac("2015",regi,teVRE) and p_avCapFac2015(regi,teVRE)) = | ||
p_histCapFac("2015",regi,teVRE) / p_avCapFac2015(regi,teVRE); | ||
|
||
loop(t $ (t.val ge 2015 AND t.val lt 2030), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, all teVRE now scale their capacity factor between 2015 and 2030. Happy to change that if something else makes more sense @robertpietzcker. Also we could think of using 2020 historical cf instead of 2015.
Previously, it was different for each technology but i could not find why:
- spv scaled from 2015 to 2030.
- csp did not use historical cf.
- wind scaled from 2015 to 2035 (but comments said 2045).
- windoff scaled from 2015 to 2035 but with missing data causing the bug.
|
||
loop(t $ (t.val ge 2015 AND t.val lt 2030), | ||
pm_cf(t,regi,teVRE) = | ||
pm_cf(t,regi,teVRE) !! always 1 for VRE in f_cf, but could be modified by modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before these lines, pm_cf is always 1 for teVRE. It might be modified by modules though .. but i think this would then happen later in the code.
In conclusion, i think we can delete this factor, but not sure..
@robertpietzcker @LaviniaBaumstark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for finding and fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Purpose of this PR
This PR puts fixes vm_capFac windoff that had very low near-term values in most regions. I think it is good to integrate this PR as part of the release validation.
VRE capacity factors are interpolated between historical values (p_aux_capacityFactorHistOverREMIND) and a default factor 1. For offshore however, p_aux_capacityFactorHistOverREMIND was not set in some regions, therefore taking the value zero and leading to very low capacity factors in the near-term:
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):
/p/tmp/fabricel/offshoreRemind09/compScen-windFixCFall-2024-10-07_17.28.43-H12-short.pdf
Scenariosxxx.1
are the ones with the corrected capacity factors.SE electricity
PE