bug fix in 45_carbonprice realization expoLinear #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurinks
commented
Aug 8, 2024
| s45_co2_tax_startyear "level of CO2 tax in start year in T$/GtC" | ||
| ; | ||
| parameter | ||
| p45_tau_co2_tax_inc(all_regi) "Linear annual increase in carbon price T$/GtC/yr" |
There was a problem hiding this comment.
In PR #1747, I had replaced the parameter p45_tau_co2_tax_inc(all_regi) by the scalar s45_tau_co2_tax_inc because the carbon price trajectory is the same for all regions. However, since pm_taxCO2eq(t,regi) is defined separately for each region, it is more convenient to keep it as a parameter. Now, the change is reversed.
laurinks
commented
Aug 8, 2024
| p45_tau_co2_tax_inc(regi) = sum(ttot$(ttot.val eq cm_expoLinear_yearStart),((pm_taxCO2eq(ttot, regi) - pm_taxCO2eq(ttot - 1, regi)) / (pm_ttot_val(ttot) - pm_ttot_val(ttot - 1)))); | ||
| pm_taxCO2eq(ttot,regi)$(ttot.val gt cm_expoLinear_yearStart) = sum(t$(t.val eq cm_expoLinear_yearStart), pm_taxCO2eq(t, regi) + p45_tau_co2_tax_inc(regi) * (pm_ttot_val(ttot) - pm_ttot_val(t))) ; | ||
| *** calculate tax path until cm_expoLinear_yearStart (defaults to 2060) | ||
| pm_taxCO2eq(t,regi) = s45_co2_tax_startyear*cm_co2_tax_growth**(t.val-cm_startyear); |
There was a problem hiding this comment.
Using set t instead of ttot.
laurinks
commented
Aug 8, 2024
| pm_taxCO2eq(t,regi) = s45_co2_tax_startyear*cm_co2_tax_growth**(t.val-cm_startyear); | ||
| *** use linear tax path from cm_expoLinear_yearStart on (with slope given by last timestep before cm_expoLinear_yearStart) | ||
| p45_tau_co2_tax_inc(regi) = sum(ttot$(ttot.val eq cm_expoLinear_yearStart), | ||
| ((pm_taxCO2eq(ttot, regi) - pm_taxCO2eq(ttot - 1, regi)) / (pm_ttot_val(ttot) - pm_ttot_val(ttot - 1)))); !! Using ttot to make use of pm_ttot_val |
There was a problem hiding this comment.
No changes. Kept ttot to make use of pm_ttot_val (instead of introducing pm_t_val).
laurinks
commented
Aug 8, 2024
| p45_tau_co2_tax_inc(regi) = sum(ttot$(ttot.val eq cm_expoLinear_yearStart), | ||
| ((pm_taxCO2eq(ttot, regi) - pm_taxCO2eq(ttot - 1, regi)) / (pm_ttot_val(ttot) - pm_ttot_val(ttot - 1)))); !! Using ttot to make use of pm_ttot_val | ||
| pm_taxCO2eq(t,regi)$(t.val gt cm_expoLinear_yearStart) = sum(t2$(t2.val eq cm_expoLinear_yearStart), pm_taxCO2eq(t2, regi)) | ||
| + p45_tau_co2_tax_inc(regi) * (t.val - cm_expoLinear_yearStart); |
There was a problem hiding this comment.
Using t instead of ttot. Improving readability by taking second term out of the pseudo sum.
laurinks
commented
Aug 8, 2024
| *** set carbon price constant after 2110 to prevent huge carbon prices which lead to convergence problems | ||
| pm_taxCO2eq(ttot,regi)$(ttot.val gt 2110) = pm_taxCO2eq("2110",regi); | ||
| pm_taxCO2eq(t,regi)$(t.val gt 2110) = pm_taxCO2eq("2110",regi); |
There was a problem hiding this comment.
Using t instead of ttot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Bug fix in 45_carbonprice realization "expoLinear": Changing a parameter into a scalar (because it does not depend on the region) in a previous PR was created a problem and is reversed now.
Type of change
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctly