Remove alternative 32_power realizations that are not used anymore #1769
Conversation
core/equations.gms
Outdated
| + ( (2020 - t.val)/15 * fm_dataglob("learnMult_wFC",teLearn) | ||
| *** 2005 to 2020: linear transition from global 2005 to regional 2020 | ||
| *** to phase-in the observed 2020 regional variation from input-data | ||
| + ( (2020 - t.val) / (2020-2015) * fm_dataglob("learnMult_wFC",teLearn) |
There was a problem hiding this comment.
Why did you replace 15 by 2020-2015 = 5?
There was a problem hiding this comment.
Just to hide some bugs for more fun in the future 🤷
It's a mistake thanks for digging and finding it!
There was a problem hiding this comment.
It looks good from my side, although I still don't understand why this changes the testOneRegi behavior as noticed here. I would prefer if you could wait for @LaviniaBaumstark's approval before merging, maybe she has an idea.
Thanks for the clean-up.
Yes let's do that! |
|
Now that we understand why the issue with testOneRegi occurred, I think we can merge this PR. What do you think @orichters @fbenke-pik ? |
|
Fine from my side. |
| + sum(prodSeOth2te(enty2,te), vm_prodSeOth(t,regi,enty2,te) ) | ||
| + sum(prodSeOth2te(enty2,te), v_prodSeOth(t,regi,enty2,te) ) !! *** RLDC removal | ||
| + vm_Mport(t,regi,enty2) | ||
| =e= | ||
| sum(se2fe(enty2,enty3,te), vm_demSe(t,regi,enty2,enty3,te)) | ||
| + sum(se2se(enty2,enty3,te), vm_demSe(t,regi,enty2,enty3,te)) | ||
| + sum(demSeOth2te(enty2,te), vm_demSeOth(t,regi,enty2,te) ) | ||
| + sum(demSeOth2te(enty2,te), v_demSeOth(t,regi,enty2,te) ) !! *** RLDC removal |
There was a problem hiding this comment.
Is !! *** RLDC removal intended to conway any information?
There was a problem hiding this comment.
no, they are anchors for remaining todos (related to this SeOth issue with which you helped me today)
Purpose of this PR
In module 32_power, only IntC is used (see conversation and corresponding issue).
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information (optional):
/p/tmp/fabricel/powerRealizations/output