Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for scenario based quantity targets #1756

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Renato-Rodrigues
Copy link
Member

@Renato-Rodrigues Renato-Rodrigues commented Jul 24, 2024

Purpose of this PR

  • Add support for scenario based quantity targets
  • Previously quantity targets were only defined directly in the scenario config file by using switch cm_implicitQttyTarget. This limited direct documentation in the code of the values used for quantity targets, and the complexity and number of quantity targets applied to any given scenario due to the GAMS 255 characters line limits.
  • This PR adds support for defining scenarios that represent specific quantity targets and use keyword to enable them in any given scenario.
  • You can find more detail about how to use this feature in the main.gms switch documentation.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
    /p/projects/ecemf/REMIND/2040_scenarios/v08_2024_06_14_REMIND_3.3.1/output

@Renato-Rodrigues Renato-Rodrigues marked this pull request as ready for review July 24, 2024 12:21
Copy link
Contributor

@robertpietzcker robertpietzcker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Renato-Rodrigues Renato-Rodrigues merged commit 251d4e6 into remindmodel:develop Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants