Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steepen wind offshore ramp-up #1753

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

lecfab
Copy link
Contributor

@lecfab lecfab commented Jul 18, 2024

Purpose of this PR

In this issue, we see that wind-offshore near-term development is too weak.
This PR implements a temporary solution (option 1 in the issue): the upper-bound on offshore follows a fast s-curve instead of a slower sort-of-linear increase.

Next step will be to define offshore as an independent technology with its own historical data and bounds,

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here: /p/tmp/fabricel/offshoreRemind
  • Comparison of results (what changes by this PR?):

Before (AMT) / after:
image

@lecfab lecfab changed the title Offshore nearterm Steepen wind offshore ramp-up Jul 19, 2024
@LaviniaBaumstark
Copy link
Member

why is this PR still open?

@lecfab lecfab merged commit 0b1cac2 into remindmodel:develop Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants