Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some adjustments to diffCurvPhaseIn2Lin, add Laurin as author #1729

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jul 4, 2024

Purpose of this PR

  • ttot$((ttot.val ge cm_startyear) is t
  • update docu: convergence year is 2050, not 2040
  • fix warning in climate assessment because file does not yet exist
  • relax fixOnRef precision to avoid 'errors' such as 0.0000139 % deviation
  • add Laurin as new author + add some orcids

Type of change

  • Refactoring
  • Author update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters merged commit 6d0ea62 into remindmodel:develop Jul 9, 2024
2 checks passed
@orichters orichters deleted the 45fix branch July 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants