Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tax convergence reporting in modelSummary #1728

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • was broken since all iterations were tracked, as p80_convNashTaxrev was replaced by p80_convNashTaxrev_iter
  • now again prints the following to the log and to remindstatus on the cluster:
No failed markets in fulldata.gdx.
Failed tax convergence in fulldata.gdx:
 - IND: 2080
 - MEA: 2070, 2080, 2090
 - REF: 2070, 2080, 2090, 2100, 2110, 2130, 2150
 - SSA: 2070, 2080

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • No need to update the changelog CHANGELOG.md

@orichters orichters merged commit a3244b3 into remindmodel:develop Jul 5, 2024
2 checks passed
@orichters orichters deleted the modelsum branch July 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants