Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix R complaining about if in output.R #1715

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jun 24, 2024

Purpose of this PR

/p/tmp/rahelma/ElevateWP2_3/SSPupdated/remind3.3.1/remind/output/ELV_LTS_T44_2024-06-20_10.17.29/log.txt on new cluster:

Error in all(is.na(output)) || output == "NA" : 
  'length = 5' in coercion to 'logical(1)'
Calls: prepareAndRun -> run -> sys.source -> eval -> eval

Probably newer R version on the new cluster treats that differently

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • adjusting the reporting in remind2 was not needed
  • I did not adjust forbiddenColumnNames in readCheckScenarioConfig.R as this PR did not lead to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test): testOneRegi fails with Modelstat after 1 iterations: 5 (Locally Infeasible)
  • No need to adjust the changelog CHANGELOG.md.

```
Error in all(is.na(output)) || output == "NA" :
  'length = 5' in coercion to 'logical(1)'
Calls: prepareAndRun -> run -> sys.source -> eval -> eval
```
@orichters orichters merged commit 053169a into remindmodel:develop Jun 25, 2024
2 checks passed
@orichters orichters deleted the patchoutput branch July 11, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants