Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yet another set of improvements to the emission market convergence algorithm and debugging information #1707

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Renato-Rodrigues
Copy link
Member

@Renato-Rodrigues Renato-Rodrigues commented Jun 17, 2024

Purpose of this PR

  • Avoid repeating calculation of the CO2 tax rescale factor in region groups.
  • Improving CO2 tax slope corner cases handling to be more reliable and speed up the convergence time.
  • Improving the report of the rescale factor calculation method for better debugging and future improvements.
  • Avoiding oscillatory behavior on CO2 tax rescaling by dampening the rescale factor if necessary.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
    /p/projects/ecemf/REMIND/2040_scenarios/v08_2024_06_14_REMIND_3.3.1/output

@Renato-Rodrigues Renato-Rodrigues marked this pull request as ready for review June 18, 2024 19:39
@Renato-Rodrigues
Copy link
Member Author

@robertpietzcker pinging for revision

Copy link
Contributor

@robertpietzcker robertpietzcker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you fine-tuned it to get your runs converged, I guess it will improve convergence :-)

@Renato-Rodrigues Renato-Rodrigues merged commit 72abc95 into remindmodel:develop Jul 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants