try to download input files once per gamscompile if missing #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklein-pik
reviewed
Jun 5, 2024
| @@ -243,6 +243,10 @@ if (any(c("--reprepare", "--restart") %in% flags)) { | |||
| slurmConfig <- "direct" | |||
| message("\nTrying to compile ", nrow(scenarios), " selected runs...") | |||
| lockID <- gms::model_lock() | |||
| if (length(missingInputData()) > 0) { | |||
| # try to fix missing input data, but only once at the beginning, not for every scenario | |||
| updateInputData(readDefaultConfig("."), remindPath = ".", gamsCompile = FALSE) | |||
There was a problem hiding this comment.
Is it a problem, that at this point the cfg is not yet configured and we have to use the defaults?
There was a problem hiding this comment.
No. Because if one of the scenarios has a different cfg, this line will trigger a reload anyway. So what might happen if you want to compile a REMIND-EU config file and some input files are missing, that it first downloads REMIND-H12 and then again REMIND-EU. But well, it doesn't break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
./start.R --gamscompilefails with some config files because another run was interrupted on thestandbypartition while distributing input files.^it doesn't match anymore.Type of change
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctly