Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ariadne develop #1676

Closed
wants to merge 134 commits into from
Closed

Conversation

fschreyer
Copy link
Contributor

Purpose of this PR

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

pweigmann and others added 30 commits April 4, 2023 11:14
…dy set by default as desired and remove old ariadne import switches
…switch starting low in 2025 and reaching switch value only in 2040
…SMkup_ind switch starting low in 2025 and reaching switch value only in 2040
…ealization to only be active if cm_startyear is greater than 2005
…arginal adjustment cost due to vm_deltaCap change from current to next time step
…o be a certain share of the SE demand of the importing region. The implementation checks convergence of trade quantities over iterations.
…s by applying the correct carbon price parameter
…e lag anymore between plastics production and plastic waste, i.e. plastics are incinerated in the same time step in which they are produced
```
Error in all(is.na(output)) || output == "NA" :
  'length = 5' in coercion to 'logical(1)'
Calls: prepareAndRun -> run -> sys.source -> eval -> eval
```
@LaviniaBaumstark
Copy link
Member

what ist the status of this PR?

@fschreyer
Copy link
Contributor Author

These changes will be dealt with in other PRs. This one can be closed.

@fschreyer fschreyer closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants