Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cement process emissions variable for conopt #1673

Merged
merged 4 commits into from
May 22, 2024

Conversation

JakobBD
Copy link
Contributor

@JakobBD JakobBD commented May 15, 2024

Purpose of this PR

So far, cement process emissions were fixed to a value based on the previous iteration's ue_cement.
ue_cement therefore only saw energy-related emissions as an incentive for reduction.

This PR makes cement process emissions a function of ue_cement in the current iteration, such that CONOPT sees the incentive to reduce ue_cement.

I still have to check and clean up the fixing of vm_macBase and vm_emiIndBase in core/presolve.gms, as process cement CCS cost enters the budget equation twice right now.

TBD if we like the results, and if we want to do some ad-hoc adaptation, e.g. to CES elasticities.

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here: /p/tmp/jakobdu/remind_temp2
  • Comparison of results (what changes by this PR?):

image

…iteration, such that CONOPT sees the incentive to reduce ue_cement
@JakobBD JakobBD changed the title make cement process emissions a function of ue_cement make cement process emissions variable for conopt May 15, 2024
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

I tested this too, same result (unsurprisingly).
image
Weird to see these differences between AMT and stock develop runs, though.
I do not see any point in adjusting CES elasticities over this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I would split this in two: the small change of moving vm_emiIndBase("co2cement_process") from presolve into an equation, that has a lot of impact on model behaviour, and the large code shuffling involving fixed_shares, that has no influence on model behaviour at all.

core/declarations.gms Outdated Show resolved Hide resolved
modules/37_industry/subsectors/equations.gms Outdated Show resolved Hide resolved
modules/37_industry/subsectors/presolve.gms Show resolved Hide resolved
@JakobBD JakobBD force-pushed the penalize_cementprocessemi branch from e9367ab to c1a1b0d Compare May 16, 2024 15:49
@JakobBD JakobBD mentioned this pull request May 21, 2024
14 tasks
@JakobBD
Copy link
Contributor Author

JakobBD commented May 21, 2024

Doing final tests on this after separating the fixed_shares refactoring (same directory as above, newest two runs).
From my side ready to merge once these tests have passed.

@JakobBD JakobBD marked this pull request as ready for review May 22, 2024 07:13
@JakobBD
Copy link
Contributor Author

JakobBD commented May 22, 2024

Tests came back fine, ready to merge from my point of view.

@JakobBD JakobBD merged commit e234ac4 into remindmodel:develop May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants