Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated MAGICC7/AR6 climate assessments between REMIND iterations #1653

Merged
merged 68 commits into from
May 27, 2024

Conversation

tonnrueter
Copy link
Contributor

@tonnrueter tonnrueter commented Apr 4, 2024

Purpose of this PR

The 15_climate REMIND module now offers the ar6 option. This runs a single scenario MAGICC7 climate emulation via IIASA's climate-assessment to obtain the global mean temperature based on REMIND generated emission data. Previously we used the same simple climate model integration for AR6 Climate assessment on reporting

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

gabriel-abrahao and others added 30 commits September 7, 2023 10:08
Basis for MAGICC7/AR6-REMIND coupling
…t_conv init value set to 1; fixed in-file module names
Copy link
Contributor

@gabriel-abrahao gabriel-abrahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this one. The only thing that is really MAGICC7 specific in this realization is the parameter sets we currently use, but even that would take just new files, no changes in the interface, to use another OpenSCM-available model such as FAIR. RIght now, using FAIR instead of MAGICC would just be a matter of adding a flag to one of the Python calls. So I really think MAGICC7 should not be in the name of the new realization.

@tonnrueter
Copy link
Contributor Author

I disagree with this one. The only thing that is really MAGICC7 specific in this realization is the parameter sets we currently use, but even that would take just new files, no changes in the interface, to use another OpenSCM-available model such as FAIR. RIght now, using FAIR instead of MAGICC would just be a matter of adding a flag to one of the Python calls. So I really think MAGICC7 should not be in the name of the new realization.

I think it'd be beneficial to have separate module realizations for different SCMs. I see your point here, however currently MAGICC is the de-facto standard for SCM integration in REMIND. Also there's more to come regarding climate assessment integration: I'm working on a PIAM pacakage remindClimateAssessment that will interface REMIND with SCMs more broadly. Once we have that adding further realizations, e.g. with FAIR as SCM should be easy, yet it makes sense to me to keep them in dedicated climate module realization e.g. modules/15_climate/FAIR

@LaviniaBaumstark
Copy link
Member

I disagree with this one. The only thing that is really MAGICC7 specific in this realization is the parameter sets we currently use, but even that would take just new files, no changes in the interface, to use another OpenSCM-available model such as FAIR. RIght now, using FAIR instead of MAGICC would just be a matter of adding a flag to one of the Python calls. So I really think MAGICC7 should not be in the name of the new realization.

I think it'd be beneficial to have separate module realizations for different SCMs. I see your point here, however currently MAGICC is the de-facto standard for SCM integration in REMIND. Also there's more to come regarding climate assessment integration: I'm working on a PIAM pacakage remindClimateAssessment that will interface REMIND with SCMs more broadly. Once we have that adding further realizations, e.g. with FAIR as SCM should be easy, yet it makes sense to me to keep them in dedicated climate module realization e.g. modules/15_climate/FAIR

I see Gabriel's point. But that would also mean, that ar6 is no better name. Than the moduel should be caled climate_assessmant or openSCM, etc.

@gabriel-abrahao
Copy link
Contributor

I agree, I'm in favor of openSCM.

Copy link
Contributor

@gabriel-abrahao gabriel-abrahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a mistake on the call to the TIRF script, which I fixed but is untested since the cluster is down. As the old implementation is very likely to stop working on the new cluster, I'm approving this PR anyway so the people who need the TIRF (@fpiontek @orichters ?) can at least try. Me and Tonn will be testing this as soon as the cluster is back.

@gabriel-abrahao gabriel-abrahao merged commit 521be1c into remindmodel:develop May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants