-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated MAGICC7/AR6 climate assessments between REMIND iterations #1653
Conversation
Basis for MAGICC7/AR6-REMIND coupling
…t_conv init value set to 1; fixed in-file module names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this one. The only thing that is really MAGICC7 specific in this realization is the parameter sets we currently use, but even that would take just new files, no changes in the interface, to use another OpenSCM-available model such as FAIR. RIght now, using FAIR instead of MAGICC would just be a matter of adding a flag to one of the Python calls. So I really think MAGICC7 should not be in the name of the new realization.
I think it'd be beneficial to have separate module realizations for different SCMs. I see your point here, however currently MAGICC is the de-facto standard for SCM integration in REMIND. Also there's more to come regarding climate assessment integration: I'm working on a PIAM pacakage |
I see Gabriel's point. But that would also mean, that |
I agree, I'm in favor of |
…lls, Report runtimes in sec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a mistake on the call to the TIRF script, which I fixed but is untested since the cluster is down. As the old implementation is very likely to stop working on the new cluster, I'm approving this PR anyway so the people who need the TIRF (@fpiontek @orichters ?) can at least try. Me and Tonn will be testing this as soon as the cluster is back.
Purpose of this PR
The
15_climate
REMIND module now offers thear6
option. This runs a single scenario MAGICC7 climate emulation via IIASA'sclimate-assessment
to obtain the global mean temperature based on REMIND generated emission data. Previously we used the same simple climate model integration for AR6 Climate assessment on reportingType of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):