Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove plotCDR and convergenceCheck #1630

Merged
merged 1 commit into from
Mar 21, 2024
Merged

remove plotCDR and convergenceCheck #1630

merged 1 commit into from
Mar 21, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Mar 20, 2024 •
edited
Loading

Purpose of this PR

Removes no longer needed output scripts, see also pik-piam/remind2#572

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)

@fbenke-pik fbenke-pik requested review from LaviniaBaumstark and removed request for LaviniaBaumstark March 21, 2024 09:04
@fbenke-pik fbenke-pik closed this Mar 21, 2024
@fbenke-pik fbenke-pik reopened this Mar 21, 2024
@fbenke-pik fbenke-pik changed the title remove plotCDR and plotIterations remove plotCDR and convergenceCheck Mar 21, 2024
@fbenke-pik fbenke-pik marked this pull request as ready for review March 21, 2024 09:14
@fbenke-pik
Copy link
Contributor Author

@LaviniaBaumstark does this require a changelog entry?

@LaviniaBaumstark
Copy link
Member

I do not think so

@fbenke-pik fbenke-pik merged commit f2993cd into remindmodel:develop Mar 21, 2024
3 checks passed
@fbenke-pik fbenke-pik deleted the cleanup branch March 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaviniaBaumstark LaviniaBaumstark LaviniaBaumstark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbenke-pik @LaviniaBaumstark