Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'make test-fix': check-fix and then test #1625

Merged
merged 2 commits into from
Mar 20, 2024
Merged

add 'make test-fix': check-fix and then test #1625

merged 2 commits into from
Mar 20, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Mar 19, 2024 •
edited
Loading

Purpose of this PR

Type of change

  • New feature

Checklist:

  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test-fix)

@orichters orichters force-pushed the testfix branch 3 times, most recently from e076c24 to 5b76090 Compare March 19, 2024 11:18
@orichters orichters marked this pull request as ready for review March 19, 2024 11:18
@orichters orichters merged commit 03b49a8 into remindmodel:develop Mar 20, 2024
2 checks passed
@orichters orichters deleted the testfix branch March 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbenke-pik fbenke-pik fbenke-pik approved these changes

@LaviniaBaumstark LaviniaBaumstark Awaiting requested review from LaviniaBaumstark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make check telling about warnings, but not showing warnings, defeats its purpose
2 participants
@orichters @fbenke-pik