-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict definition of q37_feedstockShares #1599
restrict definition of q37_feedstockShares #1599
Conversation
test runs are running in the above mentioned folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine so far from the NPi run at:
/p/tmp/simonlei/this-is-remind/remind/output/SSP2EU-NPi_2024-03-05_13.38.14
I would just resolve the conflicts (capitalization of some sets) and I would be fine with the merge.
…restrict-equations
@mellamoSimon, do mellamoSimon#8. |
q37_FossilFeedstock_Base
that was set up by @fschreyer to prevent the model from using biomass or synfuels in baseline runs. However, I think that now that might be unnecessary because we improved emissions accounting (including incineration) and we are not supposed to use |
I'm halting this merge, cause the tests failed for |
|
…ict-equations fix contradiction between q37_feedstocksShares and q37_FossilFeedstock_Base
I strated new tests in the same folder |
The current REMIND input gdxes are thoroughly broken, so I started a second test with the previous input gdx ( |
Quick update as Michaja is out of the office for the rest of this week. Below is the summary for this run:
So I'm not sure if I should merge yet. Maybe a new calibration will fix things but I don't know about the workflow in this case: should we re-calibrate and test first and then merge? Thanks!
|
The change in this PR fixes a clear bug that is currently active in the REMIND code. |
[ FAIL 0 | WARN 0 | SKIP 6 | PASS 80 ] :) |
Purpose of this PR
restrict the definition of q37_feedstockShares to relevant sets.
Type of change
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly/p/tmp/simonlei/this-is-remind/remind/output/
and here/p/tmp/pehl/Remind/output/SSP2EU-NPi_2024-03-06_11.31.54
with a working input gdx.