Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure NDC run has not lower taxes than BAU #1574

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Feb 22, 2024

Purpose of this PR

  • close https://github.com/remindmodel/development_issues/issues/236
  • NDC always has a BAU run in order to calculate an emission target for those countries that have no NDC at all. It makes no sense if NDC has lower carbon prices than BAU
  • Load bau prices and use them as a minimum value
  • also load historical data in case someone uses NDC module for <= 2020

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here: /p/tmp/oliverr/remind/output/SSP2EU-NDC_2024-02-22_13.35.12: just one iteration to see whether everything works

@orichters orichters self-assigned this Feb 22, 2024
@orichters orichters marked this pull request as ready for review February 22, 2024 15:37
@orichters orichters merged commit 40378b2 into remindmodel:develop Feb 27, 2024
2 checks passed
@orichters orichters deleted the ndcnpi branch March 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants