Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prefix of p37_specFeDem to pm_specFeDem #1553

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

JakobBD
Copy link
Contributor

@JakobBD JakobBD commented Feb 15, 2024

Purpose of this PR

Was used outside 37

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please, also run make test

@JakobBD
Copy link
Contributor Author

JakobBD commented Feb 16, 2024

Have done so over night

@JakobBD JakobBD merged commit a1d79ca into remindmodel:develop Feb 16, 2024
2 checks passed
@JakobBD JakobBD deleted the rename_specFeDem_parameter branch April 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants