-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faster make test #1538
faster make test #1538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Adding a EU21 run is maybe advisable, but also time-consuming as new input data has to be downloaded and distributed twice (before and after the run)
Definitely test EU21
. Download times are not an issue on the cluster, people can always test there, or cache locally if they are so inclined.
But changes in regional aggregation are a much more serious source of errors then different module realisations, in my experience.
@@ -183,11 +183,6 @@ if (any(! file.exists(c(path_settings_coupled, path_settings_remind))) || | |||
stop("Missing files or directories, see in red above.") | |||
} | |||
|
|||
if ("--gamscompile" %in% flags && ! file.exists("input/source_files.log")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is not needed anymore, as runGamsCompile
does that alone
ab3a186
to
b82e9a3
Compare
Something went wrong with the rebase, not fixing it now as #1539 will lead to merge conflicts anyway so that has to be redone anyway. |
Ok, including the EU21 run, time is down from ~22 to 14 min. |
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q: Thanks for the comment, I added SSP2EU-EU21-Base to the list of scenarios to be compiled, maybe you can remove "changes requested". |
Sure. I thought you planned on making a new merge request in order to not deal with the conflicts. |
Purpose of this PR
action = c
, runRscript start.R --gamscompile
. Is somehow much faster (2 min -> 30 seconds)Type of change
Checklist:
FAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly