Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update output scripts #1508

Merged
merged 1 commit into from
Dec 15, 2023
Merged

update output scripts #1508

merged 1 commit into from
Dec 15, 2023

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Dec 12, 2023 •
edited
Loading

Purpose of this PR

Updates output scripts. This removes a no longer supported output script dashboard and adds the new output script nashAnalysis. This is a single run output script that creates various plots that help with analysis of the nash convergence of a given run.

Depends on pik-piam/remind2#494

Type of change

  • Refactoring
  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)

@fbenke-pik fbenke-pik self-assigned this Dec 12, 2023
@fbenke-pik fbenke-pik marked this pull request as ready for review December 13, 2023 13:06
robertpietzcker
robertpietzcker approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@robertpietzcker robertpietzcker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fbenke-pik fbenke-pik merged commit 73fc5bc into remindmodel:develop Dec 15, 2023
2 checks passed
@fbenke-pik fbenke-pik deleted the nash branch December 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpietzcker robertpietzcker robertpietzcker approved these changes

Assignees

@fbenke-pik fbenke-pik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbenke-pik @robertpietzcker